improve performance of property reordering during feature decoding#561
Open
cportele wants to merge 1 commit into
Open
improve performance of property reordering during feature decoding#561cportele wants to merge 1 commit into
cportele wants to merge 1 commit into
Conversation
The schema-order reordering pass sorted each object's children with a comparator that re-resolved a node's schema position on every comparison, and the coalesce step resolved it again two or three times per child, so the per-path lookup ran O(n log n) times for a node with n children. Cache the resolved position on the node - computed once per reordering pass, where the mapping is constant - so each node is resolved at most once. Output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema-order reordering pass sorted each object's children with a comparator that re-resolved a node's schema position on every comparison, and the coalesce step resolved it again two or three times per child, so the per-path lookup ran O(n log n) times for a node with n children.
Cache the resolved position on the node - computed once per reordering pass, where the mapping is constant - so each node is resolved at most once. Output is unchanged.